[v10.x] backport npm 6.14.4 and notarization for macOS#32528
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: nodejs#31459 Refs: nodejs#29216 Refs: sindresorhus/macos-terminal-size#3 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
PR-URL: nodejs#32495 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Includes hardened-runtime patch from gdams from nodejs#29216 (comment) PR-URL: nodejs#31459 Refs: nodejs#29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
nodejs-github-bot added build 
Member
richardlau commented Mar 28, 2020
Will also need nodejs/build#2203 for notarization to occur. |
Member
rvagg commented Mar 30, 2020
We need nodejs/build#2203 to land for this to build any releases, the codesigning command doesn't work on the older Xcode we use. I think that PR is ready to land so we should be able to get that done and then land this straight after. |
rvagg approved these changes Mar 30, 2020
Member
rvagg left a comment
rvagg left a comment There was a problem hiding this comment.
I think I had a PR for this somewhere already, but it's basically this without npm so 👍
4 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Apr 2, 2020
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
Backport-PR-URL: #32528 PR-URL: #31459 Refs: #29216 Refs: sindresorhus/macos-terminal-size#3 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
Backport-PR-URL: #32528 PR-URL: #32495 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
Includes hardened-runtime patch from gdams from #29216 (comment) Backport-PR-URL: #32528 PR-URL: #31459 Refs: #29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
ContributorAuthor
MylesBorins commented Apr 2, 2020
landed in aa7d369...8a0ed8f |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable notarized build for macOS 10.15. It does not include f67028d61a as it does not seem like the BUILDING.md on 10.x has documentation regarding build infrastructure