lib: replace BigUInt64Array global by the primordials#31194
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added process 
ContributorAuthor
Sebastien-Ahkrin commented Jan 5, 2020
Refs: #30697 |
targos approved these changes Jan 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
Sebastien-Ahkrinforce-pushed the BigUint64ArrayPrimordials branch from ed37e3e to 2b819daCompare
trivikr approved these changes Jan 5, 2020
cjihrig approved these changes Jan 5, 2020
jasnell approved these changes Jan 6, 2020
BridgeAR approved these changes Jan 6, 2020
Trott approved these changes Jan 7, 2020
Collaborator
nodejs-github-bot commented Jan 7, 2020
Member
Trott commented Jan 7, 2020
Landed in 4f51c12 |
Trott pushed a commit that referenced this pull request Jan 7, 2020
PR-URL: #31194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
PR-URL: #31194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
PR-URL: #31194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
For this PR I have added BigUInt64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".
And just add Set.
I hope this new PR will help you :x