n-api: return napi_invalid_arg on napi_create_bigint_words#31312
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs.
legendecasforce-pushed the napi_bigint_throwing branch from 326610c to ccc6cd5Compare
addaleax approved these changes Jan 11, 2020
cjihrig approved these changes Jan 11, 2020
tniessen approved these changes Jan 11, 2020
BridgeAR approved these changes Jan 11, 2020
BridgeAR added the author ready 
Collaborator
nodejs-github-bot commented Jan 11, 2020
Collaborator
nodejs-github-bot commented Jan 12, 2020
Trott approved these changes Jan 13, 2020
mhdawson approved these changes Jan 13, 2020
Member
mhdawson left a comment
mhdawson left a comment There was a problem hiding this comment.
LGTM since this API is still experimental and we'd discussed previously that we should be returning errors in this way versus throwing an exception.
Member
mhdawson commented Jan 13, 2020
Collaborator
nodejs-github-bot commented Jan 13, 2020
Trott pushed a commit that referenced this pull request Jan 14, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
Trott commented Jan 14, 2020
Landed in 689ab46 |
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N-API statuses shall be preferred over throwing JavaScript Errors on
checks occurred in N-APIs.
Refs: #29849
These changes shall not be made on existing N-API. But BigInt related N-API is still an experimental API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes