[v12.x] deps: revert whitespace changes on V8#32605
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
While landing some of the V8 upgrades on the v12 branch, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. This was likely caused by the use of `git node land` or a simiar tool. Revert those changes to fix our tests. Since this only reverts unwanted changes on deps/v8, and it only affects tests, don't bump v8_embedder_string.
nodejs-github-bot added v12.x v8 engine 
ContributorAuthor
mmarchini commented Apr 1, 2020
ContributorAuthor
mmarchini commented Apr 1, 2020
Extra care is needed here when landing to prevent git from stripping the trailing spaces. |
Contributor
@mmarchini if / when I land I'll use my custom git alias patchit-please = "!f(){curl -L $1.patch | git am -3}; f"
|
Collaborator
nodejs-github-bot commented Apr 1, 2020
MylesBorins changed the title 
codebytere approved these changes Apr 2, 2020
Collaborator
nodejs-github-bot commented Apr 2, 2020
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
While landing some of the V8 upgrades on the v12 branch, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. This was likely caused by the use of `git node land` or a simiar tool. Revert those changes to fix our tests. Since this only reverts unwanted changes on deps/v8, and it only affects tests, don't bump v8_embedder_string. PR-URL: #32605 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Contributor
MylesBorins commented Apr 2, 2020
V8-CI is green and the various CI failures we are seeing have 0 to do with the whitespace fixes that are present in the PR. I'm going to go ahead and land them so we can unblock other V8 PRs landed in 784df12 |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While landing some of the V8 upgrades on the v12 branch, something went
wrong and git made unecessary (and incorrect) whitespace changes to test
fixtures, which broke V8 tests. This was likely caused by the use of
git node landor a simiar tool. Revert those changes to fix our tests.Since this only reverts unwanted changes on deps/v8, and it only affects
tests, don't bump v8_embedder_string.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes