src: reduce code duplication in BootstrapNode#31465
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
Collaborator
nodejs-github-bot commented Jan 22, 2020
addaleax approved these changes Jan 22, 2020
cjihrig approved these changes Jan 22, 2020
devnexen approved these changes Jan 23, 2020
ZYSzys approved these changes Jan 23, 2020
Collaborator
nodejs-github-bot commented Jan 23, 2020
jasnell approved these changes Jan 23, 2020
lpinca approved these changes Jan 23, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Trott approved these changes Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Trott pushed a commit that referenced this pull request Jan 25, 2020
PR-URL: #31465 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Jan 25, 2020
Landed in 08f5726 |
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31465 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31465 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31465 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small simplification noticed while reading the code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes