test: remove common.PORT from test-net-write-callbacks.js#31839
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Feb 18, 2020
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
I’m also good with deleting the test entirely or moving it to parallel with a lower N.
Collaborator
nodejs-github-bot commented Feb 18, 2020
Trott added the author ready 
lpinca approved these changes Feb 18, 2020
ZYSzys approved these changes Feb 18, 2020
jasnell approved these changes Feb 18, 2020
Collaborator
nodejs-github-bot commented Feb 18, 2020
cjihrig approved these changes Feb 18, 2020
Collaborator
nodejs-github-bot commented Feb 18, 2020
Collaborator
nodejs-github-bot commented Feb 18, 2020
Collaborator
nodejs-github-bot commented Feb 18, 2020
codebytere approved these changes Feb 18, 2020
richardlau approved these changes Feb 18, 2020
MemberAuthor
Trott commented Feb 19, 2020
Pummel-specific CI, since the pummel tests are skipped in our routine pull-request CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12311/ |
Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: nodejs#31839 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trottforce-pushed the test-net-write-callbacks.js branch from 1958218 to 1c4e984CompareMemberAuthor
Trott commented Feb 20, 2020
Landed in 1c4e984 |
codebytere pushed a commit that referenced this pull request Feb 27, 2020
Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: #31839 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: #31839 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: #31839 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: #31839 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes