[v12.x backport] doc: remove em dashes#32146
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment) PR-URL: nodejs#31936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
nodejs-github-bot added doc This was referenced Mar 8, 2020
Merged
Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together in a single list. The difference is not obvious in the raw markdown but is very noticeable when rendered, appearing to be a typographical error (which it in fact is). The em dash is never needed. There are always alternatives. Remove em dashes entirely. PR-URL: nodejs#32080 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
puzpuzpuzforce-pushed the remove-dash-backport-v12.x branch from daabe16 to f5a4000Compare
MemberAuthor
It looks like Travis CI failed due to timeout in compilation phase. I've already seen such failure here: #32131 (comment) Both compilation and tests run successfully on my machine. |
puzpuzpuz changed the title 
Trott approved these changes Mar 8, 2020
This comment has been minimized.
This comment has been minimized.
MemberAuthor
It seems that there are some flaky tests remaining in
|
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Mar 8, 2020
MemberAuthor
puzpuzpuz commented Mar 9, 2020
@vdeturckheim@Qard guys, could one of you review this one? We need it to unblock #32131 |
Qard approved these changes Mar 9, 2020
BridgeAR approved these changes Mar 9, 2020
MemberAuthor
puzpuzpuz commented Mar 10, 2020
Is there something I should do here or this PR is ready to land? I have no experience with backports in core, so that's why I'm asking. |
Member
Trott commented Mar 10, 2020
Once a 12.x release is being prepared, someone on @nodejs/releasers will start landing these. I don't think there's anything to do here other than wait. Since 12.x is an LTS release, only releasers are supposed to land stuff to the 12.x-staging branch. |
MemberAuthor
puzpuzpuz commented Mar 10, 2020
codebytere approved these changes Mar 14, 2020
Member
codebytere commented Mar 14, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #32146 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together in a single list. The difference is not obvious in the raw markdown but is very noticeable when rendered, appearing to be a typographical error (which it in fact is). The em dash is never needed. There are always alternatives. Remove em dashes entirely. PR-URL: #32080 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> PR-URL: #32146 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following PRs to
12.x-staging:Both of these PRs are necessary to have a successful build on
12.x-staging. See #32131 (comment) and #32131 (comment) to understand the context.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes