test: fix test-benchmark-http#31686
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 7, 2020
MemberAuthor
addaleax approved these changes Feb 7, 2020
Trott added the author ready Collaborator
nodejs-github-bot commented Feb 7, 2020
richardlau approved these changes Feb 7, 2020
Collaborator
nodejs-github-bot commented Feb 7, 2020
Member
richardlau commented Feb 7, 2020
Did the same change land on all release lines? If so we should make sure this lands on those too. cc @nodejs/releasers |
fe39757 added a setting to a benchmark which needs to be reflected in the test. PR-URL: nodejs#31686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MemberAuthor
Trott commented Feb 8, 2020
Landed in 8a14884 |
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
fe39757 added a setting to a benchmark which needs to be reflected in the test. PR-URL: #31686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
fe39757 added a setting to a benchmark which needs to be reflected in the test. PR-URL: #31686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
fe39757 added a setting to a benchmark which needs to be reflected in the test. PR-URL: #31686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
fe39757 added a setting to a benchmark which needs to be reflected in the test. PR-URL: #31686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fe39757 added a setting to a benchmark
which needs to be reflected in the test.
I'd like to fast-track this to fix the node-daily-master CI run. Collaborators, please 👍 here to approve.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes