doc: enable visual code indication in headers#31493
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
richardlau commented Jan 24, 2020
“indicatino”? 😁 |
MemberAuthor
Trott commented Jan 24, 2020
Some screenshots:
|
MemberAuthor
Trott commented Jan 24, 2020
Commit message fixed. Thanks! |
Trott changed the title 
richardlau approved these changes Jan 24, 2020
GeoffreyBooth approved these changes Jan 24, 2020
Member
GeoffreyBooth left a comment
GeoffreyBooth left a comment There was a problem hiding this comment.
We don't also want to make the code text monospaced?
lpinca approved these changes Jan 24, 2020
MemberAuthor
Trott commented Jan 24, 2020
Yes, next PR if someone else doesn't beat me to it. I'm doing one self-contained small change at a time because nothing terrifies me more than CSS. |
Trott added the author ready doc/api_assets/style.css Outdated
There was a problem hiding this comment.
Suggested change
| font-family: inherit; |
Just delete this line and it should use the monospaced font.
Contributor
XhmikosR commented Jan 25, 2020
I'd say first move with #31492 |
Contributor
XhmikosR commented Jan 25, 2020
The we'd just need to remove 2 properties from one selector without having to worry about breaking other stuff :) |
This enables the grey background for inline code in headers. Refs: nodejs#31460 (comment) PR-URL: nodejs#31493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Jan 26, 2020
Landed in 97ac661 |
4 tasks
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This enables the grey background for inline code in headers. Refs: #31460 (comment) PR-URL: #31493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
This enables the grey background for inline code in headers. Refs: #31460 (comment) PR-URL: #31493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This enables the grey background for inline code in headers. Refs: #31460 (comment) PR-URL: #31493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the grey background for inline code in headers.
Refs: #31460 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes