add explanation bit to path.resolve description#31430
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
see nodejs#25542 for details Fixes: nodejs#25542
nodejs-github-bot added doc 
addaleax approved these changes Jan 20, 2020
cjihrig approved these changes Jan 20, 2020
devnexen approved these changes Jan 21, 2020
Trott approved these changes Jan 22, 2020
ContributorAuthor
YakovL commented Jan 22, 2020
Can somebody clarify how many approvals are required for this to get merged? :) |
Member
Two, but that's not the only requirement. Needs to be open for 48 hours and have a passing CI. https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#respect-the-minimum-wait-time-for-comments |
Member
Trott commented Jan 23, 2020
Landed in 4e3dee4. Thanks for the contribution! 🎉 |
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 23, 2020
Fixes: nodejs#25542 PR-URL: nodejs#31430 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Fixes: #25542 PR-URL: #31430 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Fixes: #25542 PR-URL: #31430 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Fixes: #25542 PR-URL: #31430 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #25542 for details
Checklist