src: Modernized unique_ptr construction#31654
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
Yuhanun changed the title 
addaleax approved these changes Feb 5, 2020
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
LGTM
Just as a side note, exceptions aren’t enabled in the Node.js source tree :)
jasnell previously approved these changes Feb 5, 2020
Author
Yuhanun commented Feb 5, 2020
Ah okay, well my bad for that :) Didn't know that, good to know though since I'm looking to make more contributions to the project :) |
Member
addaleax commented Feb 5, 2020
@Yuhanun It’s all good – like you said, it also makes the code more readable. 👍 |
cjihrig approved these changes Feb 6, 2020
Uh oh!
There was an error while loading. Please reload this page.
jasnell requested changes Feb 6, 2020
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
Needs @TimothyGu's suggestion added
Co-Authored-By: Timothy Gu <[email protected]>
jasnell approved these changes Feb 6, 2020
devsnek approved these changes Feb 6, 2020
devnexen approved these changes Feb 6, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Feb 6, 2020
fhinkel approved these changes Feb 6, 2020
TimothyGu approved these changes Feb 7, 2020
Collaborator
nodejs-github-bot commented Feb 7, 2020
Member
addaleax commented Feb 8, 2020
Landed in 9c753b3, thanks for the PR! 🎉 |
addaleax pushed a commit that referenced this pull request Feb 8, 2020
PR-URL: #31654 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31654 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31654 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31654 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
PR-URL: #31654 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesA simple first contribution.
std::unique_ptr's constructor can lead to memory leaks if the constructed value, allocated through
new, throws an exception or something that causes an immediate backtrace on the callstack.std::make_unique prevents this by allocating the memory for you, making it safer. Not only does it make it safer, it also makes it more readable.
I'm not sure whether I followed every guideline with this, but I hope I did.