meta: fixup collaborator list errors#31655
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Missing `-` characters in the list
Trott approved these changes Feb 6, 2020
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
For some other PR: We should probably make all of these one line rather than wrapping them into two lines. The line wrapping makes the markdown harder to read and has no tangible benefit that I'm aware of. Would probably need to disable a markdown lint rule with a comment or something but that should be it, I think.
MemberAuthor
jasnell commented Feb 6, 2020
👍 to fast-track |
hiroppy approved these changes Feb 6, 2020
cjihrig approved these changes Feb 6, 2020
Contributor
cjihrig commented Feb 6, 2020
Might be overkill, but we could consider a linting rule for these collaborator lists. This is far from the first time there has been a formatting/ordering issue in them. |
Member
Trott commented Feb 6, 2020
Landed in e001710 |
Trott pushed a commit that referenced this pull request Feb 6, 2020
Add missing `-` characters in the list. PR-URL: #31655 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Add missing `-` characters in the list. PR-URL: #31655 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Add missing `-` characters in the list. PR-URL: #31655 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Add missing `-` characters in the list. PR-URL: #31655 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Add missing `-` characters in the list. PR-URL: #31655 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing
-characters in the listChecklist