Skip to content

docs: Reword socket.setNoDelay()#31541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rustyconover wants to merge 5 commits into from
Closed

docs: Reword socket.setNoDelay() #31541

rustyconover wants to merge 5 commits into from

Conversation

@rustyconover
Copy link
Contributor

@rustyconoverrustyconover commented Jan 27, 2020

Change the description of socket.setNoDelay() to make it clear
that sockets have Nagle's algorithm enabled by default.

Better document the tradeoff of having the algorithm enabled.

Explain the behavior of the function based on the passed arguments.

This change is a follow up of #31539 and incorporates feedback from #7995.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@rustyconover
docs: Reword socket.setNoDelay()
9f258a4
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jan 27, 2020
lundibundi
lundibundi approved these changes Jan 27, 2020
View reviewed changes
jasnell
jasnell reviewed Jan 27, 2020
View reviewed changes
@juanarboljuanarbol mentioned this pull request Jan 28, 2020
Closed
3 tasks
ronag
ronag reviewed Jan 28, 2020
View reviewed changes
Trott
Trott reviewed Jan 29, 2020
View reviewed changes
@Trott
Copy link
Member

Trott commented Feb 1, 2020

Landed in 0fe8101

Trott pushed a commit that referenced this pull request Feb 1, 2020
@rustyconover@Trott
doc: clarify socket.setNoDelay() explanation
0fe8101
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@TrottTrott closed this Feb 1, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@rustyconover@codebytere
doc: clarify socket.setNoDelay() explanation
3ba0a22
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@rustyconover@codebytere
doc: clarify socket.setNoDelay() explanation
f01e611
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@rustyconover@codebytere
doc: clarify socket.setNoDelay() explanation
0ae5b02
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@rustyconover@codebytere
doc: clarify socket.setNoDelay() explanation
356e505
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@voxpellivoxpelli mentioned this pull request Jul 3, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@ronagronagronag approved these changes

+1 more reviewer

@lundibundilundibundilundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rustyconover@Trott@jasnell@ronag@lundibundi@nodejs-github-bot