Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
doc: add note in BUILDING.md about running make distclean#31542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
swagatata commented Jan 28, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mscdex commented Jan 28, 2020
May want to also mention the need to re-run the |
56e23fa to 2ca77d7CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Jan 29, 2020
Welcome @swagatata and thanks for the pull request. Small documentation pull requests can attract a lot of comments, so your patience is appreciated! |
mhdawson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after suggestions.
This comment has been minimized.
This comment has been minimized.
Trott commented Feb 1, 2020
I went ahead and applied the earlier nits via
|
984ed3d to 97741b7Compareswagatata commented Feb 1, 2020
I have tried to follow @Trott 's suggestions, adding a "cleaning up the build" section and "troubleshooting" section. I'm not very well versed with what exactly "make clean" does and how it differs from "make distclean" so I'd welcome some notes to add there. |
Trott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a little bit more editing. Just leaving this here so no one lands this without those edits.
Trott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved stuff around, changed headers, but the basic gist and fundamental wording is all still there, I think. PTAL.
swagatata commented Feb 7, 2020
Who can merge this? |
Trott commented Feb 7, 2020
Landed in a733c18 |
Fixes: #28675 PR-URL: #31542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #28675 PR-URL: #31542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #28675 PR-URL: #31542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #28675 PR-URL: #31542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #28675 PR-URL: #31542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #28675
Checklist