[v12.x] ESM Module update#32610
Closed
[v12.x] ESM Module update #32610
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by: Rich Trott <[email protected]> PR-URL: nodejs#32274 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot added lib / src 
MylesBorinsforce-pushed the 12.x-module-update branch 2 times, most recently from 93c6c3f to 36c911aCompare
Collaborator
nodejs-github-bot commented Apr 2, 2020
ContributorAuthor
@addaleax lots of edit: your fix has already landed fwiw |
Collaborator
nodejs-github-bot commented Apr 2, 2020
GeoffreyBooth approved these changes Apr 2, 2020
Member
GeoffreyBooth left a comment
GeoffreyBooth left a comment There was a problem hiding this comment.
Assuming this is just adding to 12 what's already merged into master/13, RSLGTM. I think the only thing we need to check, probably manually, is that the flags on 12 behave as we expect them to on 12 (i.e. I think --experimental-modules is still required on 12, so this PR shouldn't accidentally remove that).
ContributorAuthor
MylesBorins commented Apr 2, 2020
@GeoffreyBooth good catch I think that aef34fd should |
This comment has been minimized.
This comment has been minimized.
PR-URL: nodejs#31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: nodejs#31625 Reviewed-By: Jan Krems <[email protected]>
PR-URL: nodejs#32147 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: nodejs#31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Simplify complex sentence. Remove use of "straightforward". PR-URL: nodejs#32427 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#32462 Refs: nodejs#31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: nodejs#32457 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
This matches what the lint-js make target passes through the CLI. PR-URL: nodejs#32145 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: nodejs#32098 Reviewed-By: Geoffrey Booth <[email protected]>
MylesBorinsforce-pushed the 12.x-module-update branch from 34bc525 to fce87a5CompareCollaborator
nodejs-github-bot commented Apr 3, 2020
ContributorAuthor
MylesBorins commented Apr 3, 2020
@addaleax check out the last CI run where we had yet another flake with http2 flood. Thoughts? |
Collaborator
nodejs-github-bot commented Apr 3, 2020
Collaborator
nodejs-github-bot commented Apr 3, 2020
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 PR-URL: #31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 PR-URL: #31625 Reviewed-By: Jan Krems <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 PR-URL: #32147 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 PR-URL: #32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 PR-URL: #31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Simplify complex sentence. Remove use of "straightforward". Backport-PR-URL: #32610 PR-URL: #32427 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Signed-off-by: Richard Lau <[email protected]> Backport-PR-URL: #32610 PR-URL: #32462 Refs: #31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. Backport-PR-URL: #32610 PR-URL: #32457 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
This matches what the lint-js make target passes through the CLI. Backport-PR-URL: #32610 PR-URL: #32145 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Backport-PR-URL: #32610 Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: #32098 Reviewed-By: Geoffrey Booth <[email protected]>
MylesBorins added a commit that referenced this pull request Apr 3, 2020
PR-URL: #32610 Reviewed-By: Geoffrey Booth <[email protected]>
ContributorAuthor
MylesBorins commented Apr 3, 2020
landed in c0e6e60...e88960d |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
outstanding module backports.