Skip to content

meta: move maclover7 to Emeritus#31994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Mar 1, 2020
Merged

meta: move maclover7 to Emeritus #31994

Trott merged 1 commit into from
Mar 1, 2020

Conversation

@Trott
Copy link
Member

@TrottTrott commented Feb 28, 2020

In email, maclover7 confirmed that are fine to move to emeritus status.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 28, 2020
@Trott
Copy link
MemberAuthor

Trott commented Feb 28, 2020

@maclover7

MylesBorins
MylesBorins approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the hard work!

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2020
@Trott
meta: move maclover7 to Emeritus
ed16746
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: nodejs#31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@TrottTrott merged commit ed16746 into nodejs:masterMar 1, 2020
@Trott
Copy link
MemberAuthor

Trott commented Mar 1, 2020

Landed in ed16746

@TrottTrott deleted the jm branch March 1, 2020 05:07
@codebyterecodebytere mentioned this pull request Mar 3, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 3, 2020
@Trott@codebytere
meta: move maclover7 to Emeritus
ded3890
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott@codebytere
meta: move maclover7 to Emeritus
bcd0658
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott@codebytere
meta: move maclover7 to Emeritus
b6b1c16
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott@codebytere
meta: move maclover7 to Emeritus
a75aa93
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@MylesBorinsMylesBorinsMylesBorins approved these changes

@mmarchinimmarchinimmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@MylesBorins@lpinca@cjihrig@mmarchini@gireeshpunathil@BridgeAR@nodejs-github-bot