src: define noreturn attribute for windows#31467
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
addaleax approved these changes Jan 22, 2020
Collaborator
nodejs-github-bot commented Jan 22, 2020
cjihrig approved these changes Jan 22, 2020
gabrielschulhof approved these changes Jan 23, 2020
richardlau approved these changes Jan 23, 2020
devnexen approved these changes Jan 23, 2020
Trott approved these changes Jan 25, 2020
Trott added the author ready Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Collaborator
nodejs-github-bot commented Jan 25, 2020
Trott pushed a commit that referenced this pull request Jan 25, 2020
PR-URL: #31467 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Jan 25, 2020
Landed in 3188afe Thanks for the contribution! 🎉 |
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31467 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31467 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31467 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As MSVC has it's own
noreturnattribute, wouldn't it be useful to utilize it inNAPI_NO_RETURNmacro?I believe it will have almost zero impact for majority of addons, but code analysis tools would be thankful.
I am working on addon written in Swift. It appears that C module importer actually handles noreturn attributes to generate corresponding Swift interface. Which in turn affects type inference. As a result I got different compiler behavior on Windows for exactly same code as on Darwin platform.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNOTE: I had 17 failing tests on master before this change. I have 17 failing tests after this change. Took this as "pass". Would be glad if anyone correct me if tests really require attention here.