build: enable backtrace when V8 is built for PPC and S390x#32113
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
Contributor
sam-github commented Mar 6, 2020
cc: @nodejs/platform-ppc @nodejs/platform-s390 |
sam-github added ppc 
bnoordhuis approved these changes Mar 6, 2020
Uh oh!
There was an error while loading. Please reload this page.
Member
mhdawson commented Mar 6, 2020
@miladfarca can you take a look as well? |
Contributor
miladfarca commented Mar 6, 2020
Changes lgtm. |
miladfarca approved these changes Mar 6, 2020
Co-Authored-By: Ben Noordhuis <[email protected]>
Collaborator
Collaborator
nodejs-github-bot commented Mar 8, 2020
addaleax approved these changes Mar 8, 2020
Collaborator
nodejs-github-bot commented Mar 8, 2020
mmarchini pushed a commit that referenced this pull request Mar 8, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
ContributorAuthor
mmarchini commented Mar 8, 2020
Landed in c49286b |
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Apr 13, 2020
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Oct 5, 2020
Refs: nodejs/node-v8#119 PR-URL: nodejs#32113 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Oct 5, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node-v8#119
Cherry-picked from
canary-baseChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes