Skip to content

test: unset NODE_OPTIONS for cctest#31594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

test: unset NODE_OPTIONS for cctest #31594

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Jan 31, 2020

The test may fail otherwise because of behaviour changes caused
by setting the environment variable.

Fixes: #31585

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: unset NODE_OPTIONS for cctest
9719b5d
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: nodejs#31585
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 31, 2020
mhdawson
mhdawson approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28880/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 3, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28885/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 3, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28888/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 3, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28894/

jasnell pushed a commit that referenced this pull request Feb 3, 2020
@addaleax@jasnell
test: unset NODE_OPTIONS for cctest
d435dc4
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 3, 2020

Landed in d435dc4

@jasnelljasnell closed this Feb 3, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax@codebytere
test: unset NODE_OPTIONS for cctest
7c3cc94
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax@codebytere
test: unset NODE_OPTIONS for cctest
0641b19
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax@codebytere
test: unset NODE_OPTIONS for cctest
d3b82e6
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax@codebytere
test: unset NODE_OPTIONS for cctest
d2fbe80
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

+2 more reviewers

@awiboxawiboxawibox approved these changes

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cctest BaseObjectPtrTest failing on master

10 participants

@addaleax@nodejs-github-bot@jasnell@Trott@lpinca@awibox@cjihrig@richardlau@devsnek@mhdawson