Skip to content

doc: document missing properties in child_process#31342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HarshithaKP wants to merge 4 commits into from
Closed

doc: document missing properties in child_process #31342

HarshithaKP wants to merge 4 commits into from

Conversation

@HarshithaKP
Copy link
Member

@HarshithaKPHarshithaKP commented Jan 13, 2020

fixes:#27206

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jan 13, 2020
@HarshithaKP
Copy link
MemberAuthor

HarshithaKP commented Jan 13, 2020

According to my understanding, Table of Contents is autogenerated. Let me know if I am wrong.

addaleax
addaleax approved these changes Jan 13, 2020
View reviewed changes
Trott
Trott approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with entry moved to retain alphabetical order.

doc/api/child_process.md Outdated
For [`child_process.exec()`][], its value will be the name of the shell
in which the child process is launched.

### `subprocess.spawnargs`
Copy link
Member

@TrottTrottJan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spawnargs should go before spawnfile rather than after it.

Copy link
MemberAuthor

@HarshithaKPHarshithaKPJan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott, thanks. Placed it in right place.

@Trott
Copy link
Member

Trott commented Jan 16, 2020

Landed in 3299de8

@TrottTrott closed this Jan 16, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 16, 2020
@HarshithaKP@Trott
doc: document missing properties in child_process
3299de8
Add documentation for subprocess.exitCode, subprocess.signalCode, subprocess.spawnargs, and subprocess.spawnfile. PR-URL: nodejs#31342Fixes: nodejs#27206 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@HarshithaKP@codebytere
doc: document missing properties in child_process
91f5e9b
Add documentation for subprocess.exitCode, subprocess.signalCode, subprocess.spawnargs, and subprocess.spawnfile. PR-URL: #31342Fixes: #27206 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@HarshithaKP@codebytere
doc: document missing properties in child_process
c11213e
Add documentation for subprocess.exitCode, subprocess.signalCode, subprocess.spawnargs, and subprocess.spawnfile. PR-URL: #31342Fixes: #27206 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@HarshithaKP@codebytere
doc: document missing properties in child_process
b4d15a9
Add documentation for subprocess.exitCode, subprocess.signalCode, subprocess.spawnargs, and subprocess.spawnfile. PR-URL: #31342Fixes: #27206 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HarshithaKP@Trott@addaleax@nodejs-github-bot