benchmark: add default type in getstringwidth.js#31377
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the benchmark 
MemberAuthor
Trott commented Jan 16, 2020
I'd like to fast-track this to unbreak nightly CI. Please 👍 here to approve (or comment to block). |
MemberAuthor
Trott commented Jan 16, 2020
BridgeAR approved these changes Jan 16, 2020
MemberAuthor
Trott commented Jan 16, 2020
Benchmark tests CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11595/ |
sam-github approved these changes Jan 16, 2020
cjihrig approved these changes Jan 16, 2020
Contributor
mscdex commented Jan 16, 2020
It's probably better to throw instead. |
richardlau approved these changes Jan 16, 2020
MemberAuthor
Trott commented Jan 16, 2020
Might be a good enhancement in the future. Before we can do that we'd need to:
|
Trottforce-pushed the fix-getstringwidth branch from 3c7c340 to d2683edCompareMemberAuthor
Trott commented Jan 16, 2020
Landed in d2683ed |
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 PR-URL: #31377 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 PR-URL: #31377 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 PR-URL: #31377 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a benchmark test that was recently broken by a breaking
change on the master branch.
Fixes: #31372
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes