errors: remove dead code in ERR_INVALID_ARG_TYPE#31322
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the errors Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed.
Flarnaforce-pushed the errors-remove-dead-code branch from 567229e to 91e2ce2CompareFlarna changed the title 
BridgeAR approved these changes Jan 11, 2020
BridgeAR added the author ready 
Collaborator
nodejs-github-bot commented Jan 11, 2020
mscdex reviewed Jan 12, 2020
| }else{ | ||
| msg+='must be '; | ||
| } | ||
| msg+='must be '; |
Contributor
There was a problem hiding this comment.
Could simplify this further by including the literal inline inside the two conditionals above.
MemberAuthor
There was a problem hiding this comment.
I'm not that a big fan of duplication.
ZYSzys approved these changes Jan 12, 2020
cjihrig approved these changes Jan 12, 2020
lpinca approved these changes Jan 12, 2020
Trott approved these changes Jan 13, 2020
Member
Trott commented Jan 14, 2020
Landed in eb5e1dd |
Trott pushed a commit that referenced this pull request Jan 14, 2020
Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed. PR-URL: #31322 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed. PR-URL: #31322 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed. PR-URL: #31322 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed. PR-URL: #31322 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unreachable code. As
expectedis converted to anArraythe 'not ' check will be never executed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes