Skip to content

Conversation

@puzpuzpuz
Copy link
Member

#27558 changed default value for server.timeout in https, but the documentation wasn't changed. This PR fixes default description in the documentation.

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Feb 8, 2020
@mscdex
Copy link
Contributor

doc-only changes should just target the doc: subsystem in the commit message

@puzpuzpuzpuzpuzpuzforce-pushed the doc/fix-https-server-timeout-default branch from 149633c to df2d8edCompareFebruary 8, 2020 11:16
@puzpuzpuz
Copy link
MemberAuthor

@mscdex

doc-only changes should just target the doc: subsystem in the commit message

Thanks for the hint. Fixed that.

@BridgeARBridgeAR changed the title doc,https: fix default server timeoutdoc: fix https default server timeoutFeb 9, 2020
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2020
@addaleax
Copy link
Member

Landed in 26cb448

addaleax pushed a commit that referenced this pull request Feb 13, 2020
PR-URL: #31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@puzpuzpuzpuzpuzpuz deleted the doc/fix-https-server-timeout-default branch February 14, 2020 06:46
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
PR-URL: #31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpsIssues or PRs related to the https subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@puzpuzpuz@mscdex@addaleax@jasnell@lpinca@BridgeAR@trivikr@nodejs-github-bot