events: fix not emit removeListener#31847
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix not emit removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ```
nodejs-github-bot added the events 
4 tasks
addaleax approved these changes Feb 18, 2020
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
Looks good!
Do you think you could add test for this?
ContributorAuthor
fuxingZhang commented Feb 18, 2020
I don't know yet, I'm not sure, but I can learn how to do it tomorrow or the day after tomorrow |
cjihrig approved these changes Feb 18, 2020
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM, and based on your OP, you can probably use something like this as the test:
'use strict';constcommon=require('../common');constassert=require('assert');constEventEmitter=require('events');constmyEmitter=newEventEmitter();constsym=Symbol('symbol');constfn=()=>{};myEmitter.on(sym,fn);myEmitter.on('removeListener',common.mustCall((...args)=>{assert.deepStrictEqual(args,[sym,fn]);}));myEmitter.removeAllListeners();
codebytere approved these changes Feb 18, 2020
When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted.
ContributorAuthor
fuxingZhang commented Feb 19, 2020
Thank you, it was very helpful for me. |
jamesgeorge007 approved these changes Feb 19, 2020
Collaborator
nodejs-github-bot commented Feb 19, 2020
ZYSzys approved these changes Feb 19, 2020
lpinca approved these changes Feb 19, 2020
jasnell approved these changes Feb 19, 2020
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Mar 7, 2020
Member
ronag commented Mar 7, 2020
CI was 404, started another one |
Trott pushed a commit that referenced this pull request Mar 7, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Mar 7, 2020
Landed in 1b3dbc9. Thanks for the contribution! 🎉 |
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>codebytere pushed a commit that referenced this pull request Mar 17, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>codebytere pushed a commit that referenced this pull request Mar 30, 2020
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () =>{}; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) =>{console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn)}); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: #31847 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix not emit removeListener when eventName type is 'symbol'.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes