Skip to content

meta: move princejwesley to emeritus#31730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

meta: move princejwesley to emeritus #31730

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Feb 11, 2020

princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
meta: move princejwesley to emeritus
544a559
princejwesley confirmed in email that moving to emeritus at this time was appropriate.
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 11, 2020
@Trott
Copy link
MemberAuthor

Trott commented Feb 11, 2020

@princejwesley

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
@addaleax
Copy link
Member

addaleax commented Feb 13, 2020

Landed in ff82b76

addaleax pushed a commit that referenced this pull request Feb 13, 2020
@Trott@addaleax
meta: move princejwesley to emeritus
ff82b76
princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: #31730 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott@codebytere
meta: move princejwesley to emeritus
15c8d9e
princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: #31730 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott@codebytere
meta: move princejwesley to emeritus
04bf5bf
princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: #31730 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott@codebytere
meta: move princejwesley to emeritus
2ae5aff
princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: #31730 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott@codebytere
meta: move princejwesley to emeritus
c222d56
princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: #31730 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@TrottTrott deleted the emeritus-2 branch April 14, 2022 11:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@ZYSzysZYSzysZYSzys approved these changes

+1 more reviewer

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Trott@addaleax@jasnell@targos@cjihrig@devsnek@gireeshpunathil@BridgeAR@ZYSzys@nodejs-github-bot