test: mark test-worker-prof flaky on linux#32589
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MylesBorins added the fast-track ContributorAuthor
MylesBorins commented Mar 31, 2020
fast-track please |
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Mar 31, 2020
richardlau approved these changes Mar 31, 2020
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
We could alternatively add as a SLOW test in https://github.com/nodejs/node/blob/master/test/root.status which would skip it in the debug containered CI.
3 tasks
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: nodejs#26401
MylesBorinsforce-pushed the test-worker-prof-flake branch from 1266676 to 91bdc35CompareCollaborator
nodejs-github-bot commented Mar 31, 2020
ContributorAuthor
MylesBorins commented Mar 31, 2020
@richardlau I've updated with your suggestion, seems more appropriate |
Collaborator
nodejs-github-bot commented Mar 31, 2020
gireeshpunathil approved these changes Apr 1, 2020
Collaborator
nodejs-github-bot commented Apr 1, 2020
Collaborator
nodejs-github-bot commented Apr 1, 2020
4 tasks
sam-github approved these changes Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: #26401 PR-URL: #32589 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
ContributorAuthor
MylesBorins commented Apr 1, 2020
landed in 18b3383 |
MylesBorins added a commit that referenced this pull request Apr 1, 2020
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: #26401 PR-URL: #32589 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: #26401 PR-URL: #32589 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: #26401 PR-URL: #32589 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently failing on ubuntu1804_sharedlibs_debug_x64
Refs: #26401