deps,test: update to uvwasi 0.0.4#31363
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the wasi 
Member
richardlau commented Jan 15, 2020
It's probably not a major thing since it's just a warning but nodejs/uvwasi#72 didn't make it into this release? |
ContributorAuthor
cjihrig commented Jan 15, 2020
Oops. I'll fix that. |
devnexen approved these changes Jan 15, 2020
tniessen approved these changes Jan 16, 2020
Trott approved these changes Jan 16, 2020
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths.
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp.
Original commit message: nodejs/uvwasi@20fd9e2 was accidentally reverted in nodejs/uvwasi#73. This commit relands it.
Collaborator
nodejs-github-bot commented Jan 17, 2020
richardlau approved these changes Jan 17, 2020
Collaborator
nodejs-github-bot commented Jan 17, 2020
Collaborator
nodejs-github-bot commented Jan 17, 2020
Collaborator
nodejs-github-bot commented Jan 17, 2020
ContributorAuthor
cjihrig commented Jan 17, 2020
^ I think the CI is passing, but a Java exception is thrown after the test suite finishes. |
cjihrig added the author ready Collaborator
Member
Trott commented Jan 17, 2020
Looks like a problem with test-requireio_pivotalagency-debian10-arm64_pi3-1. I've taken it offline. Hopefully that will fix things. /ping @rvagg |
Member
Trott commented Jan 17, 2020
Landed in e43ee37...d43e945 |
Trott pushed a commit that referenced this pull request Jan 17, 2020
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trott pushed a commit that referenced this pull request Jan 17, 2020
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trott pushed a commit that referenced this pull request Jan 17, 2020
Original commit message: nodejs/uvwasi@20fd9e2 was accidentally reverted in nodejs/uvwasi#73. This commit relands it. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Original commit message: nodejs/uvwasi@20fd9e2 was accidentally reverted in nodejs/uvwasi#73. This commit relands it. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Original commit message: nodejs/uvwasi@20fd9e2 was accidentally reverted in nodejs/uvwasi#73. This commit relands it. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Original commit message: nodejs/uvwasi@20fd9e2 was accidentally reverted in nodejs/uvwasi#73. This commit relands it. PR-URL: #31363 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes