util: throw if unreachable code is reached#31712
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the util 
Trott added wip 
Collaborator
nodejs-github-bot commented Feb 9, 2020
devsnek approved these changes Feb 10, 2020
Collaborator
nodejs-github-bot commented Feb 10, 2020
Trott added the author ready 
antsmartian approved these changes Feb 10, 2020
yosuke-furukawa approved these changes Feb 10, 2020
ZYSzys approved these changes Feb 10, 2020
jasnell approved these changes Feb 10, 2020
MemberAuthor
Trott commented Feb 11, 2020
BridgeAR approved these changes Feb 11, 2020
cjihrig approved these changes Feb 11, 2020
If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: nodejs#31712 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Landed in 3eba33e |
codebytere pushed a commit that referenced this pull request Feb 17, 2020
If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: #31712 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: #31712 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: #31712 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: #31712 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a comparison code path that is supposed to be unreachable is reached,
throw. Add a c8 comment to ignore coverage for the line, as it
should be unreachable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes