Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
test: cover property n-api null cases#31488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cover property n-api null cases #31488
Conversation
f7b7348 to f78645dCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`.
f78645d to 5f048fdComparegabrielschulhof commented Jan 24, 2020
@devnexen done. |
nodejs-github-bot commented Jan 26, 2020
Trott commented Jan 26, 2020
Landed in 42995a3 |
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: #31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: #31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere commented Mar 15, 2020
@gabrielschulhof this seems to have caused a deterministic error in Details |
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: nodejs#31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
gabrielschulhof commented Apr 21, 2020
@codebytere please see #32482 which backports the remaining bits of N-API 6 to v12.x. |
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. Backport-PR-URL: nodejs#32482 PR-URL: nodejs#31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. Backport-PR-URL: #32482 PR-URL: #31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add test coverage for passing
NULLto each parameter ofnapi.*(propert|element). In the case ofnapi_define_propertiesalsotest setting various initializer fields to
NULL.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes