[v12.x] Backport n api 6 to v12.x#32482
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
gabrielschulhof added i18n-api gabrielschulhof changed the title 
Collaborator
nodejs-github-bot commented Mar 25, 2020
Member
mhdawson commented Mar 25, 2020
@gabrielschulhof did the commits apply cleanly? |
ContributorAuthor
gabrielschulhof commented Mar 25, 2020
@mhdawson only the commit defining N-API 6 did not apply cleanly. |
Collaborator
nodejs-github-bot commented Mar 25, 2020
legendecas approved these changes Mar 27, 2020
Collaborator
nodejs-github-bot commented Mar 30, 2020
codebytereforce-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190CompareCollaborator
nodejs-github-bot commented Apr 2, 2020
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: nodejs#31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Co-Authored-By: Gabriel Schulhof <[email protected]> PR-URL: nodejs#30006 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Mark all N-APIs that have been added since version 5 as stable. PR-URL: nodejs#32058Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhofforce-pushed the backport-n-api-6-to-v12.x branch from 189b47f to 3a3c011CompareCollaborator
nodejs-github-bot commented Apr 2, 2020
Collaborator
nodejs-github-bot commented Apr 3, 2020
Collaborator
nodejs-github-bot commented Apr 7, 2020
3 tasks
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Co-Authored-By: Gabriel Schulhof <[email protected]> Backport-PR-URL: nodejs#32482 PR-URL: nodejs#30006 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. Backport-PR-URL: nodejs#32482 PR-URL: nodejs#31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Mark all N-APIs that have been added since version 5 as stable. Backport-PR-URL: nodejs#32482 PR-URL: nodejs#32058Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
targos commented Apr 25, 2020
Thanks. Landed on my WIP branch for v12.17.0: https://github.com/targos/node/commits/prepare-minor |
targos pushed a commit that referenced this pull request Apr 28, 2020
Co-Authored-By: Gabriel Schulhof <[email protected]> Backport-PR-URL: #32482 PR-URL: #30006 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. Backport-PR-URL: #32482 PR-URL: #31488 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Mark all N-APIs that have been added since version 5 as stable. Backport-PR-URL: #32482 PR-URL: #32058Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes