Skip to content

Conversation

@srl295
Copy link
Member

  • Intl was missing

Fixes: #3246

@srl295srl295 added the doc Issues and PRs related to the documentations. label Oct 7, 2015
@silverwind
Copy link
Contributor

rubber stamp LGTM.

@jasnell
Copy link
Member

LGTM

srl295 added a commit that referenced this pull request Oct 14, 2015
* Intl was missing Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3251
@jasnell
Copy link
Member

Landed in a441aa6

@jasnelljasnell closed this Oct 14, 2015
@rvaggrvagg mentioned this pull request Oct 21, 2015
@MylesBorins
Copy link
Contributor

consider for LTS

/cc @jasnell

@jasnell
Copy link
Member

Not a critical need for this

@srl295srl295 deleted the update-WORKING_GROUPS branch October 24, 2015 07:59
@srl295
Copy link
MemberAuthor

agree, not critical for LTS

.. but perhaps some such documentation should say "check the repo for the latest.." ? What if someone tried to follow a 17-and-a-half-month-old COLLABORATOR_GUIDE.md that they found in an LTS download? By 'documentation' I mean a few words at the top of the LTS version. Very low importance..

@cjihrig
Copy link
Contributor

Are docs like this even included in releases (other than built from source)? Seems like API doc changes are the important ones to backport. Files like this seem more relevant to working with the live project on GitHub.

@MylesBorins
Copy link
Contributor

considering we have been landing similar doc fixes on lts I'm going to add this to lts-watch

If no one has objections within 24 hours I'll land it into v4.x-staging

srl295 added a commit that referenced this pull request Dec 4, 2015
* Intl was missing Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3251
@jasnelljasnell mentioned this pull request Dec 17, 2015
srl295 added a commit that referenced this pull request Dec 17, 2015
* Intl was missing Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3251
srl295 added a commit that referenced this pull request Dec 23, 2015
* Intl was missing Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3251
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@srl295@silverwind@jasnell@MylesBorins@cjihrig