Release Proposal: v4.2.2 "Argon" (LTS)#3588
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jasnell commented Oct 29, 2015
Note that there are no new features. As an LTS release, this contains patch, doc and test updates only. It should be a drop in replacement for v4.2.1 and everything should just work. Please notify of any regressions as soon as possible. |
MylesBorins commented Oct 29, 2015
jasnell commented Oct 29, 2015
Additional commits we need to look at for release:
There are additional PR's on the watch list that have not yet landed: https://github.com/nodejs/node/labels/lts-watch-v4.x |
jasnell commented Oct 29, 2015
@thealphanerd ... not that I'm aware of but I don't use nvm that much |
jasnell commented Oct 29, 2015
Updated with additional commits. Will do a RC2 build tomorrow. |
Fishrock123 added meta 
rvagg commented Oct 30, 2015
These commits seem like candidates too, two test commits and the rest are docs. My thought behind including all the docs ones, including things like changing AUTHORS.md, and COLLABORATOR_GUIDE.md is that it'll make it much easier down the road if we ever need to update them given that they'll match master. Up for debate though of course.
|
rvagg commented Oct 30, 2015
If we're aiming for early next week then we're pushing it a little on our new "commits should be in a stable release already" rule since v5.0.0 just went out with all of the commits included here. They'll be in the wild over the weekend but I wouldn't be upset if this release took its time. |
rvagg commented Oct 30, 2015
Sorry for spamming this PR, but @jasnell I wanted to let you know I've added experimental I'll also end up adding |
jasnell commented Oct 30, 2015
@rvagg ... yep, which is another reason for going the v4.2.2-rc.1 route yesterday. The challenge is the timing of v5.0 release -- I'd been hoping it would have gotten out sooner ;-) |
jasnell commented Oct 30, 2015
@rvagg ... I'd likely break them down this way: Should Land:
Optional:
|
jasnell commented Oct 30, 2015
@rvagg ... ok, pushed the checked items from your list above for v4.2.2. The rest I would consider entirely optional and ok to leave out for now. |
jasnell commented Oct 30, 2015
@rvagg ... how about this: so we don't rush this out too quickly, let's do a RC2 build on Monday and give it another day or two of testing. We can do the actual release either later in the day Tuesday or Wednesday. That'll give at least another few days to see if there are any new regressions |
jasnell commented Nov 2, 2015
RC2 build running now - https://ci.nodejs.org/job/iojs+release/248/ |
rvagg commented Nov 3, 2015
sorry for late response @jasnell but I'm +1 on all your comments above |
jasnell commented Nov 3, 2015
Given that no regressions have been reported and the commits that have landed also in v5.0.0 appear to be good with no obvious new regressions there, I'll be moving ahead with the v4.2.2 release later on today. I'll kick off the build around noon pacific. /cc @nodejs/collaborators @nodejs/lts |
jasnell commented Nov 3, 2015
v4.2.2 is released |
Target release date is Monday, November 2nd
Notable changes
This is an LTS maintenance release that addresses a number of issues:
1d0f2cbf87] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #35002a45b72b4a] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #3499a6469e901a] - deps: backport 010897c from V8 upstream (Ali Ijaz Sheikh) #3520cadee67c25] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #354946c8c94055] - fs: reduced duplicate code in fs.write() (ronkorving) #29470427cdf094] - http: fix stalled pipeline bug (Fedor Indutny) #33422109708186] - lib: fix cluster handle leak (Rich Trott) #3510f49c7c6955] - lib: avoid REPL exit on completion error (Rich Trott) #33588a2c4aeeaa] - repl: handle comments properly (Sakthipriyan Vairamani) #3515a04408acce] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #23563bafe1a59b] - src: fix race condition in debug signal on exit (Ben Noordhuis) #3528fe01d0df7a] - src: fix exception message encoding on Windows (Brian White) #32884bac5d9ddf] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #33008d78d687d5] - timers: reuse timer insetTimeout().unref()(Fedor Indutny) #3407e69c869399] - tls: TLSSocket options default isServer false (Yuval Brik) #2614Release Candidate 1 Build for testing: https://nodejs.org/download/rc/v4.2.2-rc.1/