build: rectify --link-module usage#3379
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mscdex commented Oct 15, 2015
I'm not sure this was the intended behavior. @bmeck Thoughts? |
Fishrock123 commented Oct 20, 2015
ping @bmeck |
bmeck commented Oct 20, 2015
The original intent was to have as little magic as possible since the mapping of some things can be complex and not a single name (such as node's internal use of 'internal/*'). I would be more prone to allow mapping a path to a native name rather than always do this. Basically, I want it to have as little magic as possible personally. That said, there is a use case for mapping paths to different builtin names. Perhaps discussing that prior to merging anything would be for the best. |
Fishrock123 commented Oct 20, 2015
@bmeck this is just clarifying the configure option to what it actual does in more detail. LGTM if it LGTY. |
bmeck commented Oct 20, 2015
@Fishrock123 sounds good. LGTM |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123 commented Oct 20, 2015
Thanks, landed in 753509f |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins commented Oct 23, 2015
should be considered for LTS /cc @jasnell |
jasnell commented Oct 24, 2015
Can but not sure there's a critical need for it |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <[email protected]>
jasnell commented Oct 30, 2015
Landed in v4.x-staging in ad65c82 |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <[email protected]>
7 participants
Modules imported by
--link-moduleare not referenced by name but actually by path.