build: use tabs for indentation in Makefile#32614
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
richardlau approved these changes Apr 2, 2020
cjihrig approved these changes Apr 2, 2020
jasnell approved these changes Apr 2, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Apr 2, 2020
trivikr approved these changes Apr 4, 2020
Collaborator
nodejs-github-bot commented Apr 5, 2020
Collaborator
nodejs-github-bot commented Apr 5, 2020
Member
addaleax commented Apr 6, 2020
Landed in 78e6d24 |
addaleax pushed a commit that referenced this pull request Apr 6, 2020
PR-URL: #32614 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
PR-URL: #32614 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
Trott commented Apr 7, 2020
These changes appear to have broken this functionality. It now lints every .md file when one .md file is changed. Changing the tabs back to spaces fixes it so it only lints the changed file. |
Member
Trott commented Apr 7, 2020
Looks like other recipes in the Makefile get around this by not indenting lines after |
3 tasks
Member
Trott commented Apr 7, 2020
Trott added a commit to Trott/io.js that referenced this pull request Apr 10, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: nodejs#32614 (comment) PR-URL: nodejs#32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
PR-URL: #32614 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #32614 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes