build: fix LINT_MD_NEWER assignment#32712
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 2 tasks
richardlau approved these changes Apr 8, 2020
Trott added the author ready 
This comment has been minimized.
This comment has been minimized.
lpinca approved these changes Apr 8, 2020
This comment has been minimized.
This comment has been minimized.
Member
Why does indentation break functionality? It is not fully clear to me. |
MemberAuthor
If I understand correctly, a tab character at the start of a line in a Makefile indicates that the line is part of a recipe. So in this case, it causes |
Collaborator
nodejs-github-bot commented Apr 8, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: nodejs#32614 (comment) PR-URL: nodejs#32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Apr 10, 2020
Landed in 203776f |
targos pushed a commit that referenced this pull request Apr 12, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: #32614 (comment) PR-URL: #32712 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.
Refs: #32614 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes