test: flaky test-stdout-close-catch on freebsd#32849
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 14, 2020
richardlau approved these changes Apr 14, 2020
sam-github added the fast-track 
ContributorAuthor
sam-github commented Apr 14, 2020
can I fast track? |
lpinca approved these changes Apr 14, 2020
jasnell approved these changes Apr 15, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: nodejs#31280
sam-githubforce-pushed the flaky-test-stdout-close-catch branch from 5b413a5 to a4c4087Compare
BridgeAR approved these changes Apr 17, 2020
addaleax approved these changes Apr 27, 2020
addaleax added author ready Collaborator
nodejs-github-bot commented Apr 28, 2020
addaleax pushed a commit that referenced this pull request Apr 28, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Apr 28, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
addaleax commented Apr 28, 2020
Landed in 1d0b249...8e956f4 |
targos pushed a commit that referenced this pull request May 4, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #28803
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes