v10.22.0 proposal#34170
Merged
v10.22.0 proposal #34170
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <[email protected]> PR-URL: #32728Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <[email protected]> PR-URL: #32715 Backport-PR-URL: #32820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #33040 error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] ParameterList result{{},{}, context->VARARGS(),{}}; Occurs twice: ../../deps/v8/src/torque/ast-generator.cc:123:32: ../../deps/v8/src/torque/ast-generator.cc:144:32: PR-URL: #33094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Original commit message: [parser] Validate destructuring assignment pattern in correct classifier Previously we'd first accumulate errors to the parent and validate the destructuring pattern in the parent. In the case of ParseArguments this will invalidly propagate binding pattern errors from one argument to the next. The reason why ParseArguments keeps track of binding pattern errors is because it could also be used to parse async arrow function parameters. If we see async(a,b) we don't yet know whether this is the head of an async arrow function, or a call to async with arguments a and b. Bug: v8:8241 Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f Reviewed-on: https://chromium-review.googlesource.com/c/1296229 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Marja Hölttä <[email protected]> Cr-Commit-Position: refs/heads/master@{#56887} Refs: v8/v8@cd21f71Fixes: #23142 PR-URL: #33862 Reviewed-By: Richard Lau <[email protected]>
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. Backport-PR-URL: #33720 PR-URL: #27855 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz $ mv openssl-1.1.0h openssl $ git add --all openssl $ git commit openssl Backport-PR-URL: #32982 PR-URL: #32583 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz $ mv openssl-1.1.1g openssl $ git add --all openssl $ git commit openssl PR-URL: #32982 Reviewed-By: Richard Lau <[email protected]>
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: #32982 Reviewed-By: Richard Lau <[email protected]>
Behavior described in #11771 is still true even though the issue is closed. This PR is to allow DNS and URI names, even when there is not a subject. Refs: #11771 PR-URL: #22906 Reviewed-By: James M Snell <[email protected]>
This commit documents the bigint option to fs.watchFile(), which has been supported since v10.5.0. PR-URL: #32128 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This reverts commit 24a4f76. PR-URL: #32489 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
As ArrayBuffer#detach is an ecma spec operation ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)), it might be good to have it in N-API. Fixes: #29674 PR-URL: #29768 Backport-PR-URL: #33061 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbufferCloses: #29955 PR-URL: #30613 Backport-PR-URL: #33061Fixes: #29955 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
As its actual release stage. PR-URL: #30703 Backport-PR-URL: #33061 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #33307 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs-github-bot added meta 
richardlauforce-pushed the v10.22.0-proposal branch from 94abfd0 to 5cf3b31Compare
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/32192/ CITGM: https://ci.nodejs.org/job/citgm-smoker/2408/ |
Collaborator
31 tasks
MemberAuthor
richardlau commented Jul 3, 2020
rc.0 download link: https://nodejs.org/download/rc/v10.22.0-rc.0/ |
Member
@richardlau in the release commit we want plaintext, so i think we may want to change to : (no idea why gh is highlighting the pull link, if you hit edit on this comment you'll see the correct formatting) |
This was referenced Jul 4, 2020
This was referenced Jul 10, 2020
MemberAuthor
richardlau commented Jul 13, 2020
I'm waiting for the CI to complete for #34246 before landing it on master, but since the npm update fixes a low severity security advisory (GHSA-93f3-23rq-pjfp) I'm proposing we pull it into the v10.22.0 release as we don't have another 10.x release planned in the near future. This would be ahead of our usual policy of a change being released in current for two weeks before going into an LTS release. We're proposing releasing Node.js v10.22.0 on 21 July by which time the npm release will have been out in the wild (not in a Node.js release but for anything out there using the latest npm version) for two weeks. Thoughts/objections? @nodejs/lts |
PR-URL: #33239 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #34246 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau added a commit that referenced this pull request Jul 13, 2020
richardlauforce-pushed the v10.22.0-proposal branch from b4ac3b1 to eaa9e4dCompareCollaborator
If the bug this test is intented to catch is reintroduced, or if 5aac4c4 is effectively reverted, many (50+) tests time out, rendering this test redundant and unnecessary. in particular, the following timer tests catch an effective revert of 5aac4c4: not ok 21 parallel/test-timers-api-refs not ok 22 parallel/test-timers-args not ok 23 parallel/test-timers-destroyed not ok 25 parallel/test-timers-nested not ok 26 parallel/test-timers-interval-throw not ok 28 parallel/test-timers-non-integer-delay not ok 32 parallel/test-timers-ordering not ok 33 parallel/test-timers-refresh not ok 34 parallel/test-timers-refresh-in-callback not ok 35 parallel/test-timers-reset-process-domain-on-throw not ok 40 parallel/test-timers-timeout-to-interval not ok 41 parallel/test-timers-uncaught-exception not ok 42 parallel/test-timers-timeout-with-non-integer not ok 43 parallel/test-timers-unenroll-unref-interval not ok 44 parallel/test-timers-unref not ok 45 parallel/test-timers-unref-active not ok 46 parallel/test-timers-unrefd-interval-still-fires not ok 47 parallel/test-timers-unrefed-in-callback not ok 48 parallel/test-timers-user-call not ok 49 parallel/test-timers-zero-timeout Refs: #21781 PR-URL: #32870 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2. PR-URL: #33641 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MemberAuthor
richardlau commented Jul 15, 2020
richardlauforce-pushed the v10.22.0-proposal branch from eaa9e4d to c5215d0CompareCollaborator
nodejs-github-bot commented Jul 20, 2020
BethGriggs approved these changes Jul 20, 2020
Collaborator
MemberAuthor
richardlau commented Jul 21, 2020
Release build: https://ci-release.nodejs.org/job/iojs+release/6197/ |
MemberAuthor
richardlau commented Jul 21, 2020
CITGM analysis Using nodejs/node-core-utils#455 to highlight modules that failed in the CITGM run for this PR vs a CITGM run for the current The Which leaves |
BethGriggs pushed a commit that referenced this pull request Jul 21, 2020
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Jul 21, 2020
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Jul 21, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2020-07-21, Version 10.22.0 'Dubnium' (LTS), @BethGriggs prepared by @richardlau
Notable changes
napi_detach_arraybuffer(legendecas) #29768Commits
9915774d18] - build: log detected compilers in --verbose mode (Richard Lau) #32715145dcc2c1c] - build: move doc versions JSON file out of out/doc (Richard Lau) #3272824b927ab66] - build: allow clang 10+ in configure.py (Kamil Rytarowski) #2954197b59527c7] - deps: upgrade npm to 6.14.6 (claudiahdz) #3424684fca3c691] - deps: upgrade npm to 6.14.5 (Ruy Adorno) #33239745b329260] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #3298294702c1560] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32982ef9413be1a] - deps: upgrade openssl sources to 1.1.1f (Hassaan Pasha) #325833acc89f8f2] - deps: V8: backport cd21f71f9cb5 (Michaël Zasso) #3386289a306bca9] - deps: fix V8 compiler error with clang++-11 (Sam Roberts) #3309400f04e3b79] - doc: fix quotes in tls.md (Sparsh Garg) #33641193d1d0e84] - doc: document fs.watchFile() bigint option (cjihrig) #321285dab101b03] - doc,n-api: mark napi_detach_arraybuffer as experimental (legendecas) #30703069b6e14a4] - http: disable headersTimeout check when set to zero (Paolo Insogna) #33307aaf2f827c6] - inspector: more conservative minimum stack size (Ben Noordhuis) #27855b744ffd586] - (SEMVER-MINOR)n-api: implement napi_is_detached_arraybuffer (Denys Otrishko) #30613961598b9be] - (SEMVER-MINOR)n-api: addnapi_detach_arraybuffer(legendecas) #297687a109febc4] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #328703dbd8cd3a9] - Revert "test: mark empty udp tests flaky on OS X" (Luigi Pinca) #32489543656928c] - test: flaky test-stdout-close-catch on freebsd (Sam Roberts) #3284974b00cca64] - tls: allow empty subject even with altNames defined (Jason Macgowan) #22906cc @nodejs/releasers
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes