[v10.x] doc: update tls.md#33641
Closed
[v10.x] doc: update tls.md #33641
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
BridgeAR approved these changes May 30, 2020
MrHeer approved these changes May 30, 2020
lpinca approved these changes May 31, 2020
rexagod approved these changes Jun 8, 2020
Luccasoli approved these changes Jun 8, 2020
Author
sparsh-99 commented Jun 15, 2020
Hey @BridgeAR@lpinca@MrHeer@Luccasoli@rexagod , I want to know the status of this PR that why it is not merged yet? Is there any problem or something else? Please let me know. |
juanarbol approved these changes Jun 16, 2020
Member
juanarbol left a comment
juanarbol left a comment There was a problem hiding this comment.
Nice, thanks for your contribution!
Member
juanarbol commented Jun 16, 2020
@sparsh-99 your PR needs to pass the CI first, it seems like GitHub actions are not defined for |
juanarbol added land-on-v10.x author ready 
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Jul 15, 2020
Collaborator
nodejs-github-bot commented Jul 15, 2020
Collaborator
nodejs-github-bot commented Jul 15, 2020
richardlau approved these changes Jul 15, 2020
Member
richardlau commented Jul 15, 2020
Landed in 00f04e3. |
richardlau pushed a commit that referenced this pull request Jul 15, 2020
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2. PR-URL: #33641 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33631
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2
Version: v10.x
Platform: n/a
Subsystem: doc, tls