src: fix null deref in AllocatedBuffer::clear#32892
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it.
nodejs-github-bot added the c++ ContributorAuthor
fowles commented Apr 16, 2020
@soldair FYI |
2 tasks
addaleax approved these changes Apr 17, 2020
Collaborator
nodejs-github-bot commented Apr 17, 2020
devnexen approved these changes Apr 17, 2020
ContributorAuthor
fowles commented Apr 17, 2020
I don't really understand your ci system, but I suspect those are spurious failures |
Collaborator
nodejs-github-bot commented Apr 17, 2020
Contributor
hybrist commented Apr 17, 2020
Trying to resume the build, let's see if that's enough. |
hybrist approved these changes Apr 17, 2020
jasnell approved these changes Apr 18, 2020
juanarbol approved these changes Apr 18, 2020
ContributorAuthor
fowles commented Apr 21, 2020
I think this is ready to merge |
hybrist pushed a commit that referenced this pull request Apr 21, 2020
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: #32892 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Contributor
hybrist commented Apr 21, 2020
Landed in 10cc254 |
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: #32892 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: #32892 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: #32892 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: #32892 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes