src: fix null deref in AllocatedBuffer::clear#32893
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it.
nodejs-github-bot added c++ ContributorAuthor
fowles commented Apr 16, 2020
@soldair FYI |
Member
himself65 commented Apr 17, 2020
I think you shouldn't pr to |
Member
addaleax commented Apr 17, 2020
Yes, unless the change only applies to v12.x, PRs go into |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
Cherry-pick of #32892 to
v12.x branch.
Ref: #32892
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes