process: use v8 fast api calls for hrtime#33600

devsnek · 2020-05-28T05:12:27Z

This is all still very up in the air and experimental and unknown.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

[00:01:18|% 100| 1/1 files | 200/200 runs | 3/3 configs]: Done confidence improvement accuracy (*) (**) (***) process/bench-hrtime.js type='bigint' n=1000000 *** 240.17 % ±2.08% ±2.75% ±3.54% process/bench-hrtime.js type='diff' n=1000000 *** 220.36 % ±3.06% ±4.04% ±5.21% process/bench-hrtime.js type='raw' n=1000000 *** 246.85 % ±2.09% ±2.76% ±3.56%

src/node_process_methods.cc

src/api/environment.cc

src/node_process_methods.cc

devsnek · 2020-05-28T17:39:00Z

Some BaseObject tests are failing, I'm assuming because we've never had one that lives for the duration of the environment? cc @addaleax @bnoordhuis

bnoordhuis · 2020-05-28T21:02:31Z

@devsnek That's right. You can just increment the counters in the test, with a comment explaining where that BaseObject comes from.

nodejs-github-bot · 2020-05-29T16:04:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31629/

nodejs-github-bot · 2020-05-29T16:10:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31631/

nodejs-github-bot · 2020-06-05T16:32:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31734/

addaleax · 2020-06-05T16:53:27Z

I marked this as semver-major because the v8.h changes are ABI-breaking.

Do you know what embedder_wrapper_type_index is being used for`? I feel like there should be some kind of type checking involved, as right now this patch seems to imply that Node.js is the only user of fast API calls, and other users (e.g. embedders or addons) could not make use of them safely.

devsnek · 2020-06-05T16:55:39Z

@addaleax according to maya it is unused and will probably be removed. i set it to int max so if anything tries to use it it will be oob and crash.

devsnek · 2020-06-05T17:04:16Z

embedders/addons can use fast calls, but everything has to agree on the same object index. however, it sounds like automatic receiver unwrapping might be removed too, so then it won't be a problem.

addaleax · 2020-06-05T17:05:56Z

@devsnek Yes, that’s what I meant when I said “not safely” :)

devsnek · 2020-06-05T18:31:37Z

@addaleax are you good with landing this for now though?

addaleax · 2020-06-05T18:36:34Z

@devsnek I’m okay, but technically this requires another @nodejs/tsc approval as a semver-major PR.

mcollina

lgtm

Original commit message: [turbofan] Fixes for integrating the fast C API This commit adds a few fixes neccessary for integrating the fast C API into Blink: - added default constructor for CFunction - removed a bogus template specialization allowing void* params - extended the public Isolate class Bug: chromium:1052746 Change-Id: I4f2ba84299920e2cc9d66ec1ed59302313db6c0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120587 Commit-Queue: Maya Lekova <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Reviewed-by: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{#66986} Refs: v8/v8@0d6debc PR-URL: nodejs#33600 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Refs: nodejs#33374 PR-URL: nodejs#33600 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

devsnek force-pushed the fast-api-call-hrtime branch from ace156b to 431d626Compare May 28, 2020 05:12

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 28, 2020

devsnek commented May 28, 2020
View reviewed changes

src/node_process_methods.cc Outdated Show resolvedHide resolved
src/api/environment.cc Outdated Show resolvedHide resolved

devsnek added process Issues and PRs related to the process subsystem. v8 engine Issues and PRs related to the V8 dependency. labels May 28, 2020

devsnek commented May 28, 2020
View reviewed changes

src/node_process_methods.cc Outdated Show resolvedHide resolved

mscdex reviewed May 28, 2020
View reviewed changes

src/node_process_methods.cc Outdated Show resolvedHide resolved

jasnell reviewed May 28, 2020
View reviewed changes

src/node_process_methods.cc Outdated Show resolvedHide resolved

devsnek force-pushed the fast-api-call-hrtime branch from 6db6bfc to a241c15Compare May 29, 2020 03:03

devsnek marked this pull request as ready for review May 29, 2020 03:03

devsnek force-pushed the fast-api-call-hrtime branch from a241c15 to 353ee8bCompare May 29, 2020 03:09

addaleax approved these changes May 29, 2020
View reviewed changes

devsnek force-pushed the fast-api-call-hrtime branch from 353ee8b to c615909Compare May 29, 2020 16:09

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72Compare May 31, 2020 12:18

devsnek force-pushed the fast-api-call-hrtime branch from c615909 to a3f45deCompare June 5, 2020 16:29

addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 5, 2020

devsnek added dont-land-on-v10.x labels Jun 5, 2020

mcollina approved these changes Jun 6, 2020
View reviewed changes

devsnek added 2 commits June 6, 2020 11:55

process: use v8 fast api calls for hrtime
d8eef83
Refs: nodejs#33374 PR-URL: nodejs#33600 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

devsnek force-pushed the fast-api-call-hrtime branch from a3f45de to d8eef83Compare June 6, 2020 16:56

devsnek merged commit d8eef83 into nodejs:masterJun 6, 2020

devsnek deleted the fast-api-call-hrtime branch June 6, 2020 16:56

addaleax mentioned this pull request Jun 19, 2020
[v14.x] Allow passing FileHandle objects via postMessage #33965
Closed

BethGriggs mentioned this pull request Sep 1, 2020
2020-10-20, Version 15.0.0 (Current) #35014
Merged

bnoordhuis mentioned this pull request Dec 5, 2020
(fix): performance.now() should be a minimal op to avoid JSON deserialization overhead denoland/deno#8619
Merged

TimothyGu mentioned this pull request May 13, 2021
V8 Fast API Calls #38664
Closed

Uh oh!

process: use v8 fast api calls for hrtime#33600

process: use v8 fast api calls for hrtime #33600

Uh oh!

Conversation

devsnek commented May 28, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devsnek commented May 28, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis commented May 28, 2020

Uh oh!

nodejs-github-bot commented May 29, 2020

Uh oh!

nodejs-github-bot commented May 29, 2020

Uh oh!

nodejs-github-bot commented Jun 5, 2020

Uh oh!

addaleax commented Jun 5, 2020

Uh oh!

devsnek commented Jun 5, 2020

Uh oh!

devsnek commented Jun 5, 2020

Uh oh!

addaleax commented Jun 5, 2020

Uh oh!

devsnek commented Jun 5, 2020

Uh oh!

addaleax commented Jun 5, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

devsnek commented May 28, 2020•
edited
Loading

devsnek commented May 28, 2020•
edited
Loading