Skip to content

Conversation

@Voltra
Copy link
Contributor

Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.

Checklist

Reference format: `RFC <rfc id> <section path>`
@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 31, 2020
Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.
Copy link
Member

@benjamingrbenjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙇

@Ethan-Arrowood
Copy link
Contributor

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

@Voltra
Copy link
ContributorAuthor

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

If there is such interest, I would be more than happy to work on it (maybe as a follow up pull request). I'm thinking about referencing, under a new section, all status code using the following format: <code> <label> <MDN link> <IETF link> (with exceptions for codes such as 509).

@Ethan-Arrowood
Copy link
Contributor

+1 for a separate PR - feel free to tag me I'll help review 😄

Copy link
Member

@rexagodrexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! Thank you!

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2020

@VoltraVoltra requested a review from a team as a code ownerAugust 10, 2020 16:07
@rickyesrickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2020
rickyes pushed a commit that referenced this pull request Aug 15, 2020
Reference format: `RFC <rfc id> <section path>` PR-URL: #33671 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
@rickyes
Copy link
Contributor

Landed in 9594b54
@Voltra congratulations on your first commit to Node.js! 🎉

@rickyesrickyes closed this Aug 15, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
Reference format: `RFC <rfc id> <section path>` PR-URL: #33671 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
Reference format: `RFC <rfc id> <section path>` PR-URL: #33671 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Voltra@Ethan-Arrowood@nodejs-github-bot@rickyes@jasnell@benjamingr@rexagod@addaleax