V14.9.0 proposal#34852
Merged
V14.9.0 proposal #34852
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <[email protected]> Co-authored-by: Anatoli Papirovski <[email protected]> Refs: #21152 Backport-PR-URL: #34482 PR-URL: #34017 Backport-PR-URL: #34482 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Signed-off-by: Denys Otrishko <[email protected]>
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: #33140 Backport-PR-URL: #34461 PR-URL: #33609 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot added build 
This comment has been minimized.
This comment has been minimized.
PR-URL: #34672 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #34605 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: #34564 PR-URL: #34639 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #34382 PR-URL: #34383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will expose auxiliar functions to inspect heap objects using native debuggers. Fixes: #32402 Signed-off-by: Mary Marchini <[email protected]> PR-URL: #32834 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
To debug native modules node should be a debuggable process, that will require the **com.apple.security.get-task-allow** entitlement to be added to the codesign procedure. PR-URL: #34378Fixes: #34340 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Original commit message: [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes `Object::GetRealNamedPropertyAttributes()` can crash if an empty `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because it was not checking for that. Fix that. Refs: #34606 Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057 Commit-Queue: Leszek Swirski <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#69258} Refs: v8/v8@e06ace6 PR-URL: #34673Fixes: #34606 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #34606 PR-URL: #34673 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #33424 Reviewed-By: James M Snell <[email protected]>
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: #34686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684Fixes: #32863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
Two places emits `close` events: `resOnFinish` calls `emitCloseNT`, which happens when the result is completed: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L695 It gets attached once the socket is assigned: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L226 And detached if the response is completed: https://github.com/nodejs/node/blob/master/lib/_http_server.js#L709https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L232 Which means, it can only be reached in this case, for premature socket termination. PR-URL: #34472 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #34630 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Contributor
Dropping edit: @danielleadams I landed it on v14.x-staging for you |
Old versions of mocha break after #34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: #34935 Refs: mochajs/mocha#4417 Refs: #34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
Notable changes: - build: set --v8-enable-object-print by default (Mary Marchini) [#34705](#34705) - deps: - upgrade to libuv 1.39.0 (cjihrig) [#34915](#34915) - upgrade npm to 6.14.8 (Ruy Adorno) [#34834](#34834) - V8: cherry-pick e06ace6b5cdb (Anna Henningsen) [#34673](#34673) - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) [#34839](#34839) - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) [#34378](#34378) PR-URL: #34852
danielleadamsforce-pushed the v14.9.0-proposal branch from 9f971f1 to cc595f2CompareContributorAuthor
danielleadams commented Aug 26, 2020
This comment has been minimized.
This comment has been minimized.
ContributorAuthor
danielleadams commented Aug 26, 2020
Thanks, all, for the help on this! |
Collaborator
ruyadorno approved these changes Aug 26, 2020
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
Notable changes: - build: set --v8-enable-object-print by default (Mary Marchini) [#34705](#34705) - deps: - upgrade to libuv 1.39.0 (cjihrig) [#34915](#34915) - upgrade npm to 6.14.8 (Ruy Adorno) [#34834](#34834) - V8: cherry-pick e06ace6b5cdb (Anna Henningsen) [#34673](#34673) - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) [#34839](#34839) - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) [#34378](#34378) PR-URL: #34852
danielleadamsforce-pushed the v14.9.0-proposal branch from cc595f2 to 7f7d428ComparePR-URL: #34940 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
10 tasks
Notable changes: - build: set --v8-enable-object-print by default (Mary Marchini) [#34705](#34705) - deps: - upgrade to libuv 1.39.0 (cjihrig) [#34915](#34915) - upgrade npm to 6.14.8 (Ruy Adorno) [#34834](#34834) - V8: cherry-pick e06ace6b5cdb (Anna Henningsen) [#34673](#34673) - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) [#34839](#34839) - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) [#34378](#34378) PR-URL: #34852
danielleadamsforce-pushed the v14.9.0-proposal branch from 7f7d428 to 3153c2dCompareCollaborator
nodejs-github-bot commented Aug 27, 2020
BethGriggs pushed a commit that referenced this pull request Aug 27, 2020
Notable changes: - build: set --v8-enable-object-print by default (Mary Marchini) [#34705](#34705) - deps: - upgrade to libuv 1.39.0 (cjihrig) [#34915](#34915) - upgrade npm to 6.14.8 (Ruy Adorno) [#34834](#34834) - V8: cherry-pick e06ace6b5cdb (Anna Henningsen) [#34673](#34673) - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) [#34839](#34839) - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) [#34378](#34378) PR-URL: #34852
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Aug 27, 2020
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Aug 27, 2020
targos added release Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2020-08-27, Version 14.9.0 (Current), @BethGriggs prepared by @danielleadams
Notable Changes
Commits
aaa6e43d3c] - Forces Powershell to use tls1.2 (Bartosz Sosnowski) #336098de6b72efa] - benchmark: add benchmark script for resourceUsage (Yash Ladha) #34691e4450a199f] - benchmark: update function_args addon code (Anna Henningsen) #34725332e38433b] - (SEMVER-MINOR)buffer: alias UInt ➡️ Uint in buffer methods (Anna Henningsen) #347297f0869f963] - build: run link checker in linter workflow (Richard Lau) #348109ca4b2ad5c] - build: add CODEOWNERS linter action (Mary Marchini) #34739bdf26aebb4] - (SEMVER-MINOR)build: add build flag for OSS-Fuzz integration (davkor) #34761d89a83c62c] - build: move compiling for Windows ARM64 to Tier 2 (João Reis) #34721aed82379dd] - build: implement a Commit Queue in Actions (Mary Marchini) #3411215c92083b5] - build: set --v8-enable-object-print by default (Mary Marchini) #34705201d3d7074] - build: cover all benchmark addons with C++ linter (Anna Henningsen) #347252abc98e9ff] - build: add flag to build V8 with OBJECT_PRINT (Mary Marchini) #328346048421726] - build,win: use x64 Node when building for ARM64 (Dennis Ameling) #3400969bcca122e] - crypto: avoid unitializing ECDH objects on error (Tobias Nießen) #34302cf348542c6] - deps: upgrade to libuv 1.39.0 (cjihrig) #3491568b7a8db6f] - deps: upgrade npm to 6.14.8 (Ruy Adorno) #348349527a2a8a7] - deps: V8: cherry-pick e06ace6b5cdb (Anna Henningsen) #34673cd32522c92] - doc: add missing DEP ID for 'new crypto.Certificate()' (Beth Griggs) #34940ff15c92a7f] - doc: improve fs doc intro (James M Snell) #34843dae93ca0cb] - doc: indicate the format of process.version (Danny Guo) #34872bf7f492cb6] - doc: rename module pages (Antoine du HAMEL) #34663f2c2f42195] - doc: improve wording in deprecations.md (Rich Trott) #348604b3b0e3f98] - doc: fix ESM/CJS wrapper example (Maksim Sinik) #34853d6bb2ad5ea] - doc: adopt Microsoft Style Guide officially (Rich Trott) #34821e4679bd45d] - doc: use 'console' info string for console output (Rich Trott) #34837b1c3fb73fc] - doc: fix bulleted list punctuation in BUILDING.md (Rich Trott) #34849ef41ddf5cb] - doc: sort references lexically (Rich Trott) #348483133b75b68] - doc: move addaleax to TSC emeritus (Anna Henningsen) #348095214de78cd] - doc: remove space above version picker (Justice Almanzar) #3476834430abd71] - doc: move module core module doc to separate page (Antoine du HAMEL) #34747b356b79ca4] - doc: reorder deprecated tls docs (Jerome T.K. Covington) #346875c987ffc96] - doc: fix file name to main.mjs and not main.js in esm.md (Frank Lemanschik) #34786969fb1c5e3] - doc: improve async_hooks snippets (Andrey Pechkurov) #348293360dcbfab] - doc: fix some typos and grammar mistakes (Hilla Shahrabani) #3480047f2f45dd8] - doc: deprecate (doc-only) crypto.Certificate() (Rich Trott) #346973bfe199c28] - doc: remove "is recommended from crypto legacy API text (Rich Trott) #34697258f64f578] - doc: edit filehandle.close() entry in fs.md (Rich Trott) #34782e54a6842e0] - doc: fix broken links in commit-queue.md (Luigi Pinca) #347893925fd6550] - doc: avoid _may_ in collaborator guide (Rich Trott) #34749cb0960635b] - doc: use sentence-casing for headers in collaborator guide (Rich Trott) #347138b5690287c] - doc: edit (general) collaborator guide (Rich Trott) #34712b933eef1f3] - doc: reduce repetitiveness on Consensus Seeking (Mary Marchini) #34702f7563f811a] - doc: remove typo in crypto.md (Rich Trott) #34698ea98122a51] - doc: n-api environment life cycle APIs are stable (Jim Schlight) #34641b00f71b660] - doc: add padding in the sidebar column (Antoine du HAMEL) #3466591f53245ae] - doc: use semantically appropriate tag for lines (Antoine du HAMEL) #34660230bcaf276] - doc: add HPE_UNEXPECTED_CONTENT_LENGTH error description (Nikolay Krashnikov) #34596d29b805569] - doc: update http server response 'close' event (Renato Mariscal) #34472b93ba07fa5] - doc: add writable and readable options to Duplex docs (Priyank Singh) #343837cde699115] - doc: harden policy around objections (Mary Marchini) #346397d0970ca66] - doc,lib: remove unused error code (Rich Trott) #347929ebae0a758] - doc,n-api: add link to n-api tutorial website (Jim Schlight) #34870cdd4540124] - doc,tools: annotate broken links in actions workflow (Richard Lau) #34810dbcb36d553] - errors: improve ERR_INVALID_OPT_VALUE error (Denys Otrishko) #346718f38c19c08] - esm: improve error message of ERR_UNSUPPORTED_ESM_URL_SCHEME (Denys Otrishko) #347957ef5591d06] - fs: guard against undefined behavior (Robert Nagy) #34746952f233e39] - http: add RFC references for each status code (Voltra) #33671cc7258469c] - http2: fix Http2Response.sendDate (João Lucas Lucchetta) #348509e0d18fd3f] - http2: use and support non-empty DATA frame with END_STREAM flag (Carlos Lopez) #338756ee2578427] - http2: add maxHeaderSize option to http2 (Priyank Singh) #3363604defbaacd] - lib: allow to validate enums with validateOneOf (Denys Otrishko) #340701a9496a79d] - lib: add UNC support to url.pathToFileURL() (Matthew McEachen) #34743124a01d487] - lib: use full URL to GitHub issues in comments (Rich Trott) #34686756c058c45] - meta: fix codeowners docs path (Mary Marchini) #348112781f646c9] - meta: add TSC as owner of governance-related docs (Mary Marchini) #34737a69d30eb3f] - module: drop-ualias for--conditions(Richard Lau) #34935e4a0e5bc1a] - module: fix check for package.json at volume root (Derek Lewis) #34595698cae7625] - module: share CJS/ESM resolver fns, refactoring (Guy Bedford) #347446929649793] - module: custom --conditions flag option (Guy Bedford) #346379a7c87df37] - module: use cjsCache over esm injection (Guy Bedford) #3460598f7d8ec81] - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) #3483990abdd3dd4] - net: validate custom lookup() output (cjihrig) #3481384031183bc] - policy: support conditions for redirects (Bradley Farias) #34414a16f0f427e] - process: correctly parse Unicode in NODE_OPTIONS (Bartosz Sosnowski) #34476fff1e7f86c] - src: fix abort on uv_loop_init() failure (Ben Noordhuis) #348747666d95c7d] - src: usage of modernize-use-equals-default (Yash Ladha) #348073022e0d614] - src: prefer C++ empty() in boolean expressions (Tobias Nießen) #34432e16b3e72f9] - test: fix test-cluster-net-listen-relative-path.js to run in / (Rich Trott) #348202a78c33445] - test: run REPL preview test regardless of terminal type (Rich Trott) #347986b45bf3475] - test: modernize test-cluster-master-error (Anna Henningsen) #34685c080fc590d] - test: move test-inspector-already-activated-cli to parallel (Rich Trott) #347557ed7ef7ad8] - test: move execution of WPT to worker threads (Michaël Zasso) #34796e8eed5c426] - test: convert assertion that always fails to assert.fail() (Rich Trott) #34793c458e8406e] - test: remove common.rootDir (Rich Trott) #347721c324d5939] - test: allow ENOENT in test-worker-init-failure (Rich Trott) #3476988919e584b] - test: allow ENFILE in test-worker-init-failure (Rich Trott) #34769a78c638fc3] - test: use process.env.PYTHON to spawn python (Anna Henningsen) #347009a790203ed] - test: remove error message checking in test-worker-init-failure (Rich Trott) #347270472d1629a] - test: skip node-api/test_worker_terminate_finalization (Anna Henningsen) #347328e91f3ec0a] - test: fix test_worker_terminate_finalization (Anna Henningsen) #34726fd5153c822] - test: split test-crypto-dh-hash (Rich Trott) #346319f0917e656] - test: use block-scoping in test/pummel/test-timers.js (Rich Trott) #34630b261895d2b] - test: remove test-child-process-fork-args flaky designation (Rich Trott) #3468427c0653517] - test: add vm crash regression test (Anna Henningsen) #34673093a4b0ae4] - test: add tests for validateNumber/validateString (Denys Otrishko) #346725009d82b0c] - test,doc: add missing uv_setup_args() calls (cjihrig) #34751cca0372022] - (SEMVER-MINOR)timers: allow timers to be used as primitives (Denys Otrishko) #34017e90cb49390] - tls: enable renegotiation when using BoringSSL (Jeremy Rose) #348328766b5bfd5] - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) #3437877bbd73919] - util: add debug and debuglog.enabled (Bradley Farias) #33424513ab0e02f] - worker: fix --abort-on-uncaught-exception handling (Anna Henningsen) #3472403d601344a] - worker: do not crash when JSTransferable lists untransferable value (Anna Henningsen) #34766b73943e476] - workers: add support for data: URLs (Antoine du HAMEL) #34584