doc,lib: remove unused error code#34792
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the errors 
richardlau approved these changes Aug 15, 2020
Member
richardlau commented Aug 15, 2020
FWIW it looks like it was removed in 668ad44 but put back into the list of errors in e9358af. Both commits landed within a few days of each other so the reintroduction was probably unintentional. Also just spotted that "ERR_V8BREAKITERATOR" is mispelled in the commit message. |
MemberAuthor
Trott commented Aug 15, 2020
Fixed. Thanks! |
Trottforce-pushed the unused-error branch 2 times, most recently from 86fc29f to 459521bCompareMember
richardlau commented Aug 16, 2020
@Trott The error code is |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 16, 2020
MemberAuthor
Trott commented Aug 16, 2020
I guess "Fixed" implies "Fixed correctly" so I better go fix it again.... |
MemberAuthor
Trott commented Aug 16, 2020
OK, commit message error is now fixed correctly, I think and hope. |
Collaborator
nodejs-github-bot commented Aug 16, 2020
richardlau approved these changes Aug 16, 2020
richardlau added the author ready 
BridgeAR approved these changes Aug 16, 2020
lpinca approved these changes Aug 16, 2020
jasnell approved these changes Aug 17, 2020
tniessen approved these changes Aug 17, 2020
Member
jasnell commented Aug 17, 2020
fast-track? |
Collaborator
nodejs-github-bot commented Aug 17, 2020
Trott added a commit that referenced this pull request Aug 18, 2020
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: #34792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MemberAuthor
Trott commented Aug 18, 2020
Landed in 15fdd98 |
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: #34792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: #34792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: #34792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: #34792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes