module: drop -u alias for --conditions#34935
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Old versions of mocha break after nodejs#34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated.
nodejs-github-bot added the c++ 
Merged
addaleax approved these changes Aug 26, 2020
hybrist approved these changes Aug 26, 2020
Contributor
hybrist left a comment
hybrist left a comment There was a problem hiding this comment.
I expect this would affect plenty of apps that may be confused after updating node. Hopefully we can bring back the short alias in the future.
BethGriggs approved these changes Aug 26, 2020
Contributor
MylesBorins commented Aug 26, 2020
I think we should fast track this. If we hold this commit back from 14.9.0 we end up holding up a bunch of other work |
MylesBorins added the fast-track 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 26, 2020
cjihrig approved these changes Aug 26, 2020
Collaborator
nodejs-github-bot commented Aug 26, 2020
codebytere approved these changes Aug 26, 2020
Collaborator
nodejs-github-bot commented Aug 26, 2020
Contributor
MylesBorins commented Aug 26, 2020
I pinged guy 1:1 and he's +1 on this change |
Contributor
MylesBorins commented Aug 26, 2020
Landed in cc39bdf |
MylesBorins pushed a commit that referenced this pull request Aug 26, 2020
Old versions of mocha break after #34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: #34935 Refs: mochajs/mocha#4417 Refs: #34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 26, 2020
Old versions of mocha break after #34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: #34935 Refs: mochajs/mocha#4417 Refs: #34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
10 tasks
4 tasks
guybedford pushed a commit to guybedford/node that referenced this pull request Sep 28, 2020
Old versions of mocha break after nodejs#34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: nodejs#34935 Refs: mochajs/mocha#4417 Refs: nodejs#34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
codebytere pushed a commit that referenced this pull request Oct 1, 2020
Old versions of mocha break after #34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: #34935 Backport-PR-URL: #35385 Refs: mochajs/mocha#4417 Refs: #34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this for discussion. Perfectly happy if the consensus is
to close.
#34637 has exposed a bug in mocha which we see in CITGM for
the proposed 14.9.0 release. The bug has been fixed in mocha,
but several modules being tested in CITGM are pinned to older
versions of mocha and would need to be updated as they will
not automatically pick up the fix.
Old versions of mocha break after #34637.
This was a bug in mocha, but since this is a widely used module
we can expect ecosystem breakage until modules are updated to
the latest version of mocha. Drop the conflicting
-ualias --we can potentially bring it back once modules have been updated.
Refs: mochajs/mocha#4417
Refs: #34637
Refs: #34852 (comment)
cc @nodejs/modules-active-members @nodejs/releasers @boneskull
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes