Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
lib: add UNC support to url.pathToFileURL()#34743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
guybedford left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mceachen commented Aug 12, 2020
Seems like |
nodejs-github-bot commented Aug 12, 2020 • edited by rickyes
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by rickyes
Uh oh!
There was an error while loading. Please reload this page.
jasnell commented Aug 12, 2020
@mceachen ... yeah, that's a known issue. A fix is pending. |
lib/internal/url.js Outdated
| functionencodePathChars(filepath){ | ||
| if(filepath.includes('%')) | ||
| filepath=filepath.replace(percentRegEx,'%25'); | ||
| // In posix, "/" is a valid character in paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // In posix, "/" is a valid character in paths | |
| // In posix, "\" is a valid character in paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch. I just moved this comment, btw, when I refactored out the function. Will fix.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fix mistake in comment
mceachen commented Aug 13, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thanks for the reviews! Is there anything else I need to do for this PR? (I haven't committed to this project before). |
nodejs-github-bot commented Aug 14, 2020
Fixes: #34736 PR-URL: #34743 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott commented Aug 14, 2020
Landed in 7b8c6b0. Thanks for the contribution! 🎉 |
Fixes: #34736 PR-URL: #34743 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #34736 PR-URL: #34743 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #34736 PR-URL: #34743 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #34736 PR-URL: #34743 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #34736
Checklist
make -j4 test(UNIX) passesvcbuild test(Windows) passes