Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: rename module pages#34663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: rename module pages #34663
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jasnell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally -1 on this given that it will break existing links to docs in http://nodejs.org. If we can find a way of aliasing renamed pages first, so that existing links can be forwarded, that would be ideal.
guybedford commented Aug 7, 2020
Agreed it should be possible to do this without changing the existing URLs. Most importantly for the CommonJS |
9898afc to 41b2a11Compareaduh95 commented Aug 7, 2020
That's right, I haven't thought of that! I have implemented @guybedford's suggestion, PTAL. |
guybedford left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start to me, in particular renaming the existing Modules section to Modules: CommonJS Modules seems like an important change to get through at this point.
GeoffreyBooth commented Aug 10, 2020
@jasnell Do you know who the best person to talk to would be about the mechanics of the docs generation? In particular I'm wondering if anyone can advise us on how to create redirect links so that we can feel free to move or rename sections without breaking links. |
jasnell commented Aug 10, 2020
Unfortunately no. I've never done any digging into that part of the code |
richardlau commented Aug 10, 2020
Docs are built statically as part of the release process and then copied across to the staging server (see Lines 1092 to 1097 in bcfb176
latest- link (see https://nodejs.org/docs/) is updated to point to the version uploaded.I think redirects for the website are handled via https://github.com/nodejs/build/blob/master/ansible/www-standalone/resources/config/nodejs.org. That's completely outside of the docs generation process and I'm not sure there's that many people who understand how that's deployed. |
aduh95 commented Aug 12, 2020
@jasnell I've updated the PR to address your comment, would be willing to dismiss your objection or to rephrase it if this PR still needs work from me? |
aduh95 commented Aug 19, 2020
Could this be labeled Author ready? |
GeoffreyBooth commented Aug 19, 2020
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539
41b2a11 to 80bea04Compareaduh95 commented Aug 19, 2020
Rebased on master, should be good now! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GeoffreyBooth left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @Trott are you okay with the current language?
Trott commented Aug 23, 2020
Yes. |
Trott commented Aug 23, 2020
Landed in 22e3ada |
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539 PR-URL: #34663 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539 PR-URL: #34663 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539 PR-URL: nodejs#34663 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539 Backport-PR-URL: #35757 PR-URL: #34663 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: nodejs/modules#539 Backport-PR-URL: #35757 PR-URL: #34663 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Using a "Modules:" prefix groups all the related pages together when
using alphabetical order.
This is a first PR in attempt to improve package documentation. More changes are coming as discussed in nodejs/modules#539, I've decided to split into several PRs to ease the code review.
Refs: nodejs/modules#539
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes