Skip to content

src: fix abort on uv_loop_init() failure#34874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis wants to merge 1 commit into from
Closed

src: fix abort on uv_loop_init() failure #34874

bnoordhuis wants to merge 1 commit into from

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuisbnoordhuis commented Aug 22, 2020

Fixes: #34855

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Aug 22, 2020
@bnoordhuisbnoordhuis mentioned this pull request Aug 22, 2020
Closed
@lundibundilundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 22, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32889/

@Trott
Copy link
Member

Trott commented Aug 24, 2020

Landed in b8ab49f

@TrottTrott closed this Aug 24, 2020
Trott pushed a commit that referenced this pull request Aug 24, 2020
@bnoordhuis@Trott
src: fix abort on uv_loop_init() failure
b8ab49f
Fixes: #34855 PR-URL: #34874 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 25, 2020
@bnoordhuis
src: fix abort on uv_loop_init() failure
fff1e7f
Fixes: #34855 PR-URL: #34874 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Aug 25, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@bnoordhuis@addaleax
src: fix abort on uv_loop_init() failure
d0481d1
Fixes: #34855 PR-URL: #34874 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@bnoordhuis@addaleax
src: fix abort on uv_loop_init() failure
26a596b
Fixes: #34855 PR-URL: #34874 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+1 more reviewer

@lundibundilundibundilundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.child_processIssues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

6 participants

@bnoordhuis@nodejs-github-bot@Trott@cjihrig@gireeshpunathil@lundibundi