doc: improve async_hooks snippets#34829
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added async_hooks 
benjamingr approved these changes Aug 18, 2020
jasnell approved these changes Aug 18, 2020
Member
jasnell commented Aug 18, 2020
fast-track? |
jasnell added the author ready 
Flarna approved these changes Aug 18, 2020
Member
jasnell commented Aug 18, 2020
Landed in f39a121 |
jasnell pushed a commit that referenced this pull request Aug 18, 2020
PR-URL: #34829 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
PR-URL: #34829 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
PR-URL: #34829 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34829 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34829 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
This was referenced May 27, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some
fs.writeSynccalls in snippets were using1instead ofprocess.stdout.fd.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes