doc: clarify O_EXCL text in fs.md#34096
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
PR-URL: nodejs#34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Edit for clarity, correct tense, and brevity. PR-URL: nodejs#34064 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Jun 29, 2020
@nodejs/documentation |
Use shorter and more direct phrasing. PR-URL: nodejs#34063 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
PR-URL: nodejs#34072 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#34046 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#34060 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax approved these changes Jun 29, 2020
Trott added the author ready MemberAuthor
Trott commented Jun 30, 2020
@nodejs/fs |
Notable changes: - deps: V8: backport fb26d0bb1835 (Matheus Marchini) [nodejs#33573](nodejs#33573) - src: use symbol to store `AsyncWrap` resource (Anna Henningsen) [nodejs#31745](nodejs#31745) PR-URL: nodejs#34077
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#34071 Refs: nodejs#29298 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#34086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: nodejs#34087 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. PR-URL: nodejs#34102 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
bufferSize should only look at writableLength otherwise it will always show more than what is actually pending. PR-URL: nodejs#34088 Refs: nodejs#34078 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: nodejs#34088 Refs: nodejs#34078 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Notable changes: build: * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#33376 cli: * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) nodejs#33587 crypto: * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) nodejs#33360 deps: * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) nodejs#33376 * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) nodejs#33376 dgram: * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) nodejs#22413 events: * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) nodejs#33556 fs: * (SEMVER-MINOR) implement lutimes (Maël Nison) nodejs#33399 http: * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) nodejs#33803 * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) nodejs#33617 * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) added scheduling option to http agent (delvedor) nodejs#33278 http2: * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) nodejs#33994 * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) nodejs#33160 process: * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) nodejs#33475 src: * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) nodejs#33850 stream*: * runtime deprecate Transform._transformState (Robert Nagy) nodejs#32763 win: * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) nodejs#33176 worker: * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) nodejs#33979 * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) nodejs#33772 worker,fs: * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) nodejs#33772 zlib: * (SEMVER-MINOR) add `maxOutputLength` option (unknown) nodejs#33516 PR-URL: nodejs#34093
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: nodejs#34147 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
Ignore subsequent calls to set_final_size unless the new size is more than the previous, in which case, we have us a bug. PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
Use a single callback function for both PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
They introduce a significant performance bottleneck at the moment. PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
MemberAuthor
Trott commented Jul 1, 2020
@nodejs/collaborators Needs a second review. |
ryzokuken approved these changes Jul 1, 2020
Replace "is considered 'special'" with "represents a device". The latter is more clear and is derived from the stat() man page. The former is also derived from the man page, but is ambiguous because: * "considered" introduces doubt. Is it, or isn't it? * "special" is never defined. "represents a device" communicates more meaning. * "special" is in scare-quotes, introducing more doubt as to what exactly it means. Refs: https://man7.org/linux/man-pages/man2/fstat.2.html PR-URL: nodejs#34094 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
PR-URL: nodejs#34096 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
MemberAuthor
Trott commented Jul 1, 2020
Landed in 8ff8c68 |
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes